noaa-oar-arl / canopy-app

Stand-alone/column canopy codes and parameterizations
MIT License
6 stars 7 forks source link

Gamma sm #114

Closed drnimbusrain closed 7 months ago

drnimbusrain commented 8 months ago

@MaggieMarvin I have a draft branch and PR here for the gamma soil activity factor (for isoprene only), which depends on input soil moisture (in four layers) and wilting point, along with a PFT dependent cumulative root fraction used for the final weighted average gamma soil. You can please test this impact on biogenic isoprene emissions independently of my other branch/PR for historical effects. Thank you!

@angehung5 If you please can see the SE domain example gfs .NC files. I have added "soilw[1-4]" volumetric soil moistures and the "wilt" wilting points as inputs to canopy-app. Can you add the corresponding five variables ("soilw[1-4]" and "wilt") from the example .NC files as appended columns and to the example .TXT files?

You can see that it breaks the CI because the usual .txt check fails without these variables in the files.

This includes updates to the following:

gfs.t12z.20220630.sfcf023.canopy.txt gfs.t12z.20220701.sfcf000.canopy.txt gfs.t12z.20220701.sfcf001.canopy.txt point_file_20220630.sfcf023.txt point_file_20220701.sfcf000.txt point_file_20220701.sfcf001.txt

You can share with me their location for me to add to this branch for functionality when using text files, or could create a PR back to this [gamma_sm] branch for updating the text files.

Thank you!

drnimbusrain commented 8 months ago

This is currently a draft and needs thorough testing:

angehung5 commented 7 months ago

@drnimbusrain Files updated. You can also find them on Hopper: /groups/ESS/whung/canopy_wind/gfsv16_test_data

drnimbusrain commented 7 months ago

@drnimbusrain Files updated. You can also find them on Hopper: /groups/ESS/whung/canopy_wind/gfsv16_test_data

Thank you @angehung5 Seems it fixes the CI too since you added those variables to the text files. @MaggieMarvin is testing it using netcdf files against MEGAN and seems to be working appropriately. I will test your .txt files to make sure too.

drnimbusrain commented 7 months ago

Thank you Maggie!! Can you elaborate on the MEGAN3 gamma soil moisture approach for all species? Can we still use soil moisture and wilting point inputs?

On Thu, Feb 22, 2024, 2:03 PM Maggie Marvin @.***> wrote:

@.**** approved this pull request.

Looks good after bug fix! Evaluated for 08/01/2021 1800 UTC - when turned on reduces isoprene emissions mainly over croplands by up to about 50% and improves agreement slightly with MEGAN. Input data on soil moisture and wilting point looks reasonable, and gamma factor behaves as expected. In future may want to consider MEGANv3 parameterization and expanding to other species. map_canopyapp_bio_NA-12.png (view on web) https://github.com/noaa-oar-arl/canopy-app/assets/47859989/aa8c2750-e9a5-4310-aa70-daa4ecb6f529

— Reply to this email directly, view it on GitHub https://github.com/noaa-oar-arl/canopy-app/pull/114#pullrequestreview-1896730752, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLFYNQFGD2YIX6IUDZXACTYU6JAFAVCNFSM6AAAAABDAZFL2WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOJWG4ZTANZVGI . You are receiving this because you were mentioned.Message ID: @.***>

MaggieMarvin commented 7 months ago

MEGANv3 has an option to calculate gamma_sm using a photosynthesis parameter and soil wetness factor from a CLM but this may not be straightforward to implement in canopy-app. MEGANv3 otherwise uses the same parameterization from Guenther 2006 but my understanding is that it only applies soil moisture from the top layer and changes delta_theta1 to 0.04. Overall this should reduce isoprene emissions further (particularly over croplands) in our test case of 08/01/2021 1800 UTC because gamma_sm = 1 at the lowest soil layer, which is weighted more than the other layers in our current implementation.

MaggieMarvin commented 7 months ago

As far as I can tell, gamma_sm is applied to all species in MEGANv3.

drnimbusrain commented 7 months ago

As far as I can tell, gamma_sm is applied to all species in MEGANv3.

@MaggieMarvin OK, as discussed I now changed code to allow for gamma_sm applied to all species here in canopy-app too. Let me know if you are still good, and I will merge.

drnimbusrain commented 7 months ago

@MaggieMarvin Merging...