Closed zmoon closed 1 year ago
@zmoon Thank you so much for doing all of this! Understood that you should very soon turn your attention to UFS/NEXUS, but if we wrap this up it would be helpful! Thanks again.
Looks like running the example nb currently takes ~ 50 s in CI. Not bad, but will later (probably not in this PR) add parallel sensitivity run option which will help with this.
@zmoon Thank you for continuing to work and wrap up these great Python examples and binder for the tests...I think it will be a great way for us to test canopy-app more effectively!
@drnimbusrain how do we want to address the var differences?
The bio emi ones are the same, the differences are: | nc | txt |
---|---|---|
canwind |
ws |
|
flameh |
flame_height |
|
- | canopy_height |
Note that canopy height isn't in the nc output but is in the txt output.
The txt names are formed in the Python by taking those in the text output header and lowercasing and replacing ` with
_`.
@zmoon This is a great point on the inconsistent variables. I will add "canheight" to the NC output and change the txt output variable names to be consistent.
I will add "canheight" to the NC output and change the txt output variable names to be consistent.
Ok, do you want to do it in this PR?
Or let me attempt and then you can review?
@zmoon great to do it on this PR, and would appreciate if you could attempt then...
@drnimbusrain I'll remove your notes from the nb after you review, want to leave them for now so you have them.
I know I already changed it to canwind
, but in retrospect maybe ws
is better since WS above the canopy is included too, yes? Also fine with canwind
though.
Hi Zach, I am Ok with using WS for the canopy wind speed variable name. Please proceed.
On Tue, Apr 25, 2023, 11:35 AM Zachary Moon @.***> wrote:
I know I already changed it to canwind, but in retrospect maybe ws is better since WS above the canopy is included too, yes? Also fine with canwind though.
— Reply to this email directly, view it on GitHub https://github.com/noaa-oar-arl/canopy-app/pull/58#issuecomment-1522010858, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLFYNSYDHBYJDS4Q6G4SB3XC7VLTANCNFSM6AAAAAAW5O6S3A . You are receiving this because you were mentioned.Message ID: @.***>
@zmoon I think this looks great! You can remove my notes and merge.
todo: