noaa-oar-arl / monet

The Model and ObservatioN Evaluation Toolkit (MONET)
https://monet-arl.readthedocs.io
Other
44 stars 20 forks source link

Updated the function for Kolmogorov–Zurbenko (KZ) filter #80

Closed drnimbusrain closed 4 years ago

pep8speaks commented 4 years ago

Hello @drnimbusrain! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-04-01 15:45:43 UTC
bbakernoaa commented 4 years ago

@drnimbusrain This is awesome! good idea to group by siteid. When I was building it originally it didn't have this. I would like to add these resampling of regulatory stuff/time filters to the MONETPandasAccessor https://github.com/noaa-oar-arl/monet/blob/master/monet/monet_accessor.py#L244. I'll work on it. Should be easy to do :)

Then users would be able to access it directly from the pandas data frame. They wouldn't need to do monet.tools.kz_filter(df, etc......)

bbakernoaa commented 4 years ago

I'll go ahead and merge this