Open zmoon opened 1 year ago
For these tests, can mark and test with both pandas v1 and v2 to make sure changes don't break pandas v1 compat.
Would be nice to be able to check that results are the same too, easiest way would be to store the v1 results
Scheduled CI failed today due to this.
Looks like OpenAQ also needs some work to support pandas v2. @jordanschnell reported:
... @?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~T~@?~U?
AssertionError
Which seems to come from this line:
assert ( zzz[~zzz.parameter.isin(["pm25", "pm4", "pm10", "bc"])].unit.dropna() == "ppm" ).all()
and needing to update the deprecated json_normalize
call.
Note Note that the conda-forge recipe doesn't currently restrict the pandas version. Nor does the
install_requires
. So you need to specify when creating your environment or downgrade if necessary.
Some tests failing with pandas v2, noticed first in #110