noaa-oar-arl / monetio

The Model and ObservatioN Evaluation Tool I/O package
https://monetio.readthedocs.io
MIT License
16 stars 19 forks source link

New readers from MM satellite group #112

Closed rrbuchholz closed 3 weeks ago

rrbuchholz commented 1 year ago

Adding in: Tropomi L2 reader OMPS L3 reader MOPITT L3 reader and adding to __init__.py file

zmoon commented 1 year ago

@dwfncar @rrbuchholz do you have/want any tests for any of these?

zmoon commented 1 year ago

3.6 failing due to #114 , but there are also some comments from flake8 to address, and some formatting stuff. Also looks like we need to add h5py to the docs env.

rrbuchholz commented 1 year ago

I have an example Jupyter notebook for MOPITT in the MELODIES MONET develop_satellite branch that needs to be pulled. I also think Meng has added a Tropomi example and Maggie has added the OMPS L3 example in MELODIES MONET.

zmoon commented 1 year ago

@rrbuchholz that'll be great to have those MM examples, but I was referring here to smaller test cases for the MONETIO readers to add to the MONETIO test suite. It's ok if we don't have, just thought I would ask.

zmoon commented 1 year ago

Data file @rrbuchholz shared now available at https://csl.noaa.gov/groups/csl4/modeldata/melodies-monet/data/example_observation_data/satellite/MOP03JM-201701-L3V95.9.3.he5

rrbuchholz commented 2 months ago

Hi @zmoon! Just wondering what you need from us in the satellite team to get this pull request merged? Would be great to try and have it done before the summer release of MELODIES MONET. (It's been a year since we opened this!)

zmoon commented 2 months ago

Hi @rrbuchholz , very sorry, it's been on my list to get back to @mlirenzhenmayi

zmoon commented 2 months ago

@rrbuchholz and @mlirenzhenmayi I added some basic tests for the other two. I also made a few changes here and there (e.g. adding attributes to variables), maybe you can check that your workflows still work and/or review.

rrbuchholz commented 3 weeks ago

It all looks good to merge.

zmoon commented 3 weeks ago

@rrbuchholz thanks for checking it out. I haven't added @mlirenzhenmayi 's updates to tropomi but maybe it's simpler to merge this now and add that after.

rrbuchholz commented 3 weeks ago

@zmoon Yeah, I think that sounds like a good idea.