search

noaa-oar-arl / monetio

The Model and ObservatioN Evaluation Tool I/O package
https://monetio.readthedocs.io
MIT License
17 stars 19 forks source link

OpenAQ v1 fixes + initial OpenAQ v2 reader #141

Closed zmoon closed 1 week ago

zmoon commented 11 months ago

Closes #130 #122

zmoon commented 11 months ago

AQS unreachable again.

And for 3.8, additionally getting:

FAILED tests/test_openaq.py::test_openaq_first_date - TypeError: openssl_sha1() takes at most 1 argument (2 given)
FAILED tests/test_openaq.py::test_openaq_long_fmt - TypeError: openssl_sha1() takes at most 1 argument (2 given)
FAILED tests/test_openaq.py::test_openaq_2023 - TypeError: openssl_sha1() takes at most 1 argument (2 given)
zmoon commented 1 week ago

Thanks @bbakernoaa . I have this automatic warning set up: https://github.com/noaa-oar-arl/monetio/blob/4490a50d7e76bcc7d2e10d33feb5ff5ef69c53dc/monetio/obs/openaq_v2.py#L60-L67 but I will also add the relevant info to the module docstring.