noaa-oar-arl / monetio

The Model and ObservatioN Evaluation Tool I/O package
https://monetio.readthedocs.io
MIT License
17 stars 30 forks source link

feature/_camx_mm #187

Closed blychs closed 2 months ago

blychs commented 3 months ago

_camx_mm reader (redone to avoid updating more things that strictly related to this PR).

I still have not built a test. I have checked the output files that are provided by the CAMx developers, but see the following problems to add that as a test case: a) The files are provided in a tar.gz bundle, which is about 440 MB. As far as I understand, we wanted to have testcases of less than 200 MB. The file we really need is only 32 MB, but we would need to host it somewhere else. I don't know whether that would be acceptable, and I am uncertain about any licensing issues with doing that. If we also want to have the meteorological variables, they are on a separate file, which is only 24 MB for the 2D files, but 300 MB if we require 3D. b) The files provided by the CAMx are only 2D, and if we need 3D, we would have to get someone to run CAMx. I have not compiled it, and only used output that was provided to me (I don't think that I am allowed to make that public). c) CAMx output (and input) can be either netCDF or fortran binaries (UAMIV). My code is able to handle both, but we don't have examples with both available.

Let me know your thoughts. Pablo

zmoon commented 2 months ago

@blychs to me it sounds like setting up a test wouldn't be easy at this time. Maybe we can do it in the future if the data you are using becomes allowed to be public.

blychs commented 2 months ago

Agreed. I think we can move on with this (we can add a warning if you think that's advisable). Hopefully we can get public data sooner rather than later, to allow users to have a test case.

zmoon commented 2 months ago

Let's not worry about any warning for this one.