I am creating this for myself to fix (assigning it here instead of in the NCAR repo because I understand that we'd like to get rid of that one),
I can't assign in this repo, but if @zmoon or another person with writing rights can assign this to me, that would be great
There are a couple minor bugs, plus the need of adding a layer_height_agl (height at the interface, instead of mid layer) variable to be able to better calculate the columns. I only found out now while developing the TEMPO comparison for MELODIES-MONET, and getting a little bit of model output from another source.
The bugs are the following:
The pressure is converted to Pa wrongly: it should be multiplied by 100 and is instead multiplied by 1000
The names of the pressure and height variables are not consistent across simulations (f. e., the pressure is sometimes called "pressure" and sometimes "PRESS_MB", the altitude is sometimes called "ZGRID_M" and sometimes just "z"). The code should be able to deal with that on its own.
The topographic altitude is not in the met3d data, but in the 2d input. The code should be able to deal with that automatically.
Right now, if surf_only=False and any of the 3D additional variables is missing (especially, the height), the code breaks with an exception. I think that a better approach would be to raise a warning and continue running.
I am creating this for myself to fix (assigning it here instead of in the NCAR repo because I understand that we'd like to get rid of that one),
I can't assign in this repo, but if @zmoon or another person with writing rights can assign this to me, that would be great
There are a couple minor bugs, plus the need of adding a layer_height_agl (height at the interface, instead of mid layer) variable to be able to better calculate the columns. I only found out now while developing the TEMPO comparison for MELODIES-MONET, and getting a little bit of model output from another source.
The bugs are the following: