Fix bugs in layer height and temperature

noaa-oar-arl / monetio

The Model and ObservatioN Evaluation Tool I/O package

https://monetio.readthedocs.io

MIT License

17 stars 30 forks source link

Fix bugs in layer height and temperature #192

Closed blychs closed 2 months ago

blychs commented 2 months ago

Here are the fixes for the bug I mentioned. I am sorry for having to reopen a pull request about this! In short: the previous code only worked if CAMX had NETCDF input files, which is not always the case, and had a typo at calling for dset_variables. It was also not adding the temperature.

I also changed the name of layer height to make it more clear.

Cheers Pablo

zmoon commented 2 months ago

The recent commit displeased the formatter

blychs commented 2 months ago

@zmoon Just run pre-commit and black found some issues. Should be fixed now.

blychs commented 2 months ago

I just saw that the docs failed. I don't think I modified anything in them?

zmoon commented 2 months ago

It was in the link check, CRN website currently down https://www.ncei.noaa.gov/access/crn/

zmoon commented 2 months ago

https://www.ncei.noaa.gov/ is back now, but data stuff still out (giving 404)