noaa-oar-arl / monetio

The Model and ObservatioN Evaluation Tool I/O package
https://monetio.readthedocs.io
MIT License
17 stars 30 forks source link

Hotfix/_camx_mm consistent with _wrfchem_mm #197

Closed blychs closed 1 month ago

blychs commented 1 month ago

This makes the camx_mm reader consistent with wrfchem_mm by incorporating "dz_m" instad of "layer_height_agl" We had talked at the time of adapting it once the new wrfchem_mm reader was accepted.

Cheers Pablo

blychs commented 1 month ago

No, it doesn't. alg_agl_m_mid is the exact same thing here as in _wrfchem_mm. layer_height_agl was the layer height at the interface, which I was using later to create the thickness to calculate partial columns. SInce the wrfchem reader went a different way, by calculating layer thickness in the reader, I am changing it to do the same, so that future code will work for both. The TEMPO tool can already deal with the way that wrfchem does it.

blychs commented 1 month ago

That way, the TROPOMI tool (or any other) should work for both regardless, since the version loaded by MONETIO will look the same.

zmoon commented 1 month ago

The NCDC website still having an issue, causing the test failures.