search

noaa-oar-arl / monetio

The Model and ObservatioN Evaluation Tool I/O package
https://monetio.readthedocs.io
MIT License
16 stars 19 forks source link

Be more strict about RRFS-CMAQ reader PM2.5 merge #79

Closed zmoon closed 1 year ago

zmoon commented 1 year ago

Fixes #78

zmoon commented 1 year ago

The Python 3.6 run here was getting xarray 0.18.2, which has a different message in this situation. But now accounted for.

zmoon commented 1 year ago

@rschwant if you can take a quick look at some point that would be great

rschwant commented 1 year ago

This looks good to me. I like the detail of the error messages, so that it is really clear when something goes wrong. Was Jianping able to fix the float issue in his scripts, so that these files can merge properly now?

zmoon commented 1 year ago

Thanks @rschwant

Was Jianping able to fix the float issue in his scripts, so that these files can merge properly now?

I haven't gotten an update on that. I had the same issue with some RRFS-CMAQ output from Patrick, and I did some pre-processing using ds = ds.merge(ds_pm, join="exact", compat="override"), which afaik at least checks that the index shapes match.