search

noaa-oar-arl / monetio

The Model and ObservatioN Evaluation Tool I/O package
https://monetio.readthedocs.io
MIT License
16 stars 19 forks source link

_gridded_eos_mm.py reader for gridded NASA EOS hdf files #88

Closed dwfncar closed 1 year ago

dwfncar commented 1 year ago

Initial reader for gridded NASA EOS datasets, which include MODIS level 3 products. Uses monetio.sat.hdfio. Similar to monetio/sat/_modis_l2_mm.py.

dwfncar commented 1 year ago

Will fix pre-commit lint checks, mostly single quotes need to be replaced by double quotes

zmoon commented 1 year ago

@dwfncar is this ready to go?

dwfncar commented 1 year ago

Yes, ready for review and merge if OK ... David

On Thu, Oct 6, 2022 at 9:31 AM Zachary Moon @.***> wrote:

@dwfncar https://github.com/dwfncar is this ready to go?

— Reply to this email directly, view it on GitHub https://github.com/noaa-oar-arl/monetio/pull/88#issuecomment-1270275655, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALUCLABEMVRUKLSK3V6PADWB3WGHANCNFSM6AAAAAAQZHBFJY . You are receiving this because you were mentioned.Message ID: @.***>

zmoon commented 1 year ago

For next time, if you want, you can use GitHub to commit selected suggestions as a commit automatically. And I think they auto mark as resolved then too.

zmoon commented 1 year ago

@dwfncar if you want to confirm that this still works for you, I'll merge this.

dwfncar commented 1 year ago

Yes, tested reader with MODIS L3 data. We can proceed with the merge.