noaa-ocs-hydrography / kluster

A distributed multibeam processing system built using the Pangeo ecosystem
Creative Commons Zero v1.0 Universal
47 stars 12 forks source link

EM124 Data Processing in Kluster #112

Closed tzutingchen closed 10 months ago

tzutingchen commented 1 year ago

"Sonar model not understood" issue with the "em124" data

ericgyounkin commented 1 year ago

I believe this is as simple as adding an em124 entry to the sonar_translator at https://github.com/noaa-ocs-hydrography/kluster/blob/master/HSTB/kluster/xarray_conversion.py#L28, mirroring the existing em122 entry.

We'd probably need a sample file to ensure that is the case.

@barry-gallagher interested?

ericgyounkin commented 1 year ago

See also https://kluster.readthedocs.io/en/latest/for_developers/fordev_sonar.html

Sample data - https://drive.google.com/file/d/1iHW6V8-2mOdKyi5p22c26JzsfjwUXFrb/view?usp=share_link

barry-gallagher commented 1 year ago

This is possible to add but we have a fair backlog on other projects so I won't promise when we'll get to it. Probably this and #113 would get done at the same time.

tzutingchen commented 1 year ago

Thank you for your response. Looking forward to the updates.

ericgyounkin commented 10 months ago

@tzutingchen I have this working locally, I'll need to combine with the other sonar support requests and include in a new version. I'll report back here when that is done.

ericgyounkin commented 10 months ago

@tzutingchen This is fixed with v1.1.6. You should be able to reinstall and get the update.