search

noaa-ocs-hydrography / vyperdatum

Use VDatum grids in PROJ to transform points and GDAL supported raster files
Creative Commons Zero v1.0 Universal
13 stars 4 forks source link

CRS Issue #21

Closed jlwoodr closed 2 years ago

jlwoodr commented 2 years ago

Hello,

I was trying to run through the first example on the read me and keep getting the following error:

CRSError: Invalid WKT string: NAD83

I have also tried 'nad83' with no luck. I also looked through the crs.py code to find the list of acceptable strings and could not find anything. How should I go about debugging this? Thanks!

Johnathan

ericgyounkin commented 2 years ago

Sorry @jlwoodr I completely missed this issue for some reason. Let me go take a look.

Rjialceky commented 2 years ago

Initial report is that it has to do with 0- vs 1-based indexing on datum string lookup. For now, use explicit EPSG codes to specify geometric datum; e.g., in the first example, use EPSG integer code 6319 for 3D 'nad83': vp.transform_points(6319, 'mllw', x, y, z=z)

jlwoodr commented 2 years ago

That worked great! Thanks for the help.

Johnathan Woodruff

On Mon, Dec 13, 2021 at 2:54 PM Rjialceky @.***> wrote:

Initial report is that it has to do with 0- vs 1-based indexing on datum string lookup. For now, use explicit EPSG codes to specify geometric datum; e.g., in the first example, use EPSG integer code 6319 for 3D 'nad83': vp.transform_points(6319, 'mllw', x, y, z=z)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/noaa-ocs-hydrography/vyperdatum/issues/21#issuecomment-992826972, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMEHHOMMPBMWNS52IAI3EPTUQZFNZANCNFSM5JPJ43ZQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

ericgyounkin commented 2 years ago

@jlwoodr Our readme was very out of date. I updated the examples to show the correct usage. Thanks for letting us know!

Fixed in 600fc2f16fe5a95dc3a26336d5d8cd23421fef5f