noaa-ocs-hydrography / vyperdatum

Use VDatum grids in PROJ to transform points and GDAL supported raster files
Creative Commons Zero v1.0 Universal
9 stars 4 forks source link

vyperdatum not compatible with newest vdatum software? #34

Open jalland opened 1 year ago

jalland commented 1 year ago

Hello! My name is Josh Alland and I am at the National Hurricane Center. I have been trying to get vyperdatum working on my local laptop. I downloaded the recent version of vdatum first (v4.4.2), but vyperdatum is giving the following error: "OSError: Unable to find version for /Users/jalland/Downloads/vdatum/ in the currently accepted versions: ['vdatum_4.4.1_20220324', 'vdatum_4.3_20210928', 'vdatum_4.2_20210603', 'vdatum_4.1.2_20201203']"

Is there support to have vyperdatum work with the updated version of vdatum? Thank you!

ericgyounkin commented 1 year ago

Hi Josh, thanks for letting us know. I'll need to add support when I get back to the office. It honestly might be a few weeks, but I can respond here to let you know.

On Tue, Aug 16, 2022 at 3:03 PM jalland @.***> wrote:

Hello! My name is Josh Alland and I am at the National Hurricane Center. I have been trying to get vyperdatum working on my local laptop. I downloaded the recent version of vdatum first (v4.4.2), but vyperdatum is giving the following error: "OSError: Unable to find version for /Users/jalland/Downloads/vdatum/ in the currently accepted versions: ['vdatum_4.4.1_20220324', 'vdatum_4.3_20210928', 'vdatum_4.2_20210603', 'vdatum_4.1.2_20201203']"

Is there support to have vyperdatum work with the updated version of vdatum? Thank you!

— Reply to this email directly, view it on GitHub https://github.com/noaa-ocs-hydrography/vyperdatum/issues/34, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOA2JUDVU3LFV4N2ZZBYKC3VZPQXNANCNFSM56W46BYA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Eric Younkin Physical Scientist NOAA OCS, Hydrographic Systems and Technology Branch 1315 East-West Highway N/CS11, Room 6604 Silver Spring, MD 20910 Office: ‪(302) 751-0538‬ Cell: 828-331-8197

jalland commented 1 year ago

Thanks Eric! Tingzhe Si sended me an older version of vdatum that works. However, I am still not able to get vyperdatum to work property. I'm getting an error when trying to run the example code: "Pipeline "+proj=pipeline +step +proj=vgridshift grids=core\xgeoid20b\conuspac.gtx +step +inv +proj=vgridshift grids=VAswchb11_8301\tss.gtx +step +proj=vgridshift grids=VAswchb11_8301\mllw.gtx" for transformation from "[[]]" to "[+proj=pipeline +step +proj=vgridshift grids=core\xgeoid20b\conuspac.gtx +step +inv +proj=vgridshift grids=VAswchb11_8301\tss.gtx +step +proj=vgridshift grids=VAswchb11_8301\mllw.gtx]" in region "VAswchb11_8301" was flagged as invalid. Missing support files?" and "No valid region found with the specified datum transformation. Unable to perform transformation"

Any idea why this may be?

ericgyounkin commented 1 year ago

Believe it means it can't find the grid files. Can you look in VDatum to see if all the grids called out in the pipeline string exist?

On Wed, Aug 17, 2022 at 2:12 PM jalland @.***> wrote:

Thanks Eric! Tingzhe Si sended me an older version of vdatum that works. However, I am still not able to get vyperdatum to work property. I'm getting an error when trying to run the example code: "Pipeline "+proj=pipeline +step +proj=vgridshift grids=core\xgeoid20b\conuspac.gtx +step +inv +proj=vgridshift grids=VAswchb11_8301\tss.gtx +step +proj=vgridshift grids=VAswchb11_8301\mllw.gtx" for transformation from "[[]]" to "[+proj=pipeline +step +proj=vgridshift grids=core\xgeoid20b\conuspac.gtx +step +inv +proj=vgridshift grids=VAswchb11_8301\tss.gtx +step +proj=vgridshift grids=VAswchb11_8301\mllw.gtx]" in region "VAswchb11_8301" was flagged as invalid. Missing support files?" and "No valid region found with the specified datum transformation. Unable to perform transformation"

Any idea why this may be?

— Reply to this email directly, view it on GitHub https://github.com/noaa-ocs-hydrography/vyperdatum/issues/34#issuecomment-1218342781, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOA2JUBEO7MBHWLL3SIEN5DVZUTPFANCNFSM56W46BYA . You are receiving this because you commented.Message ID: @.***>

-- Eric Younkin Physical Scientist NOAA OCS, Hydrographic Systems and Technology Branch 1315 East-West Highway N/CS11, Room 6604 Silver Spring, MD 20910 Office: ‪(302) 751-0538‬ Cell: 828-331-8197

jalland commented 1 year ago

I am seeing all of the grids. Could the error be coming in from the highlighted portion?

"Pipeline

"+proj=pipeline +step +proj=vgridshift grids=core\xgeoid20b\conuspac.gtx +step +inv +proj=vgridshift grids=VAswchb11_8301\tss.gtx +step +proj=vgridshift grids=VAswchb11_8301\mllw.gtx" for transformation from "[[]]" to "[+proj=pipeline +step +proj=vgridshift grids=core\xgeoid20b\conuspac.gtx +step +inv +proj=vgridshift grids=VAswchb11_8301\tss.gtx +step +proj=vgridshift grids=VAswchb11_8301\mllw.gtx]" in region "VAswchb11_8301" was flagged as invalid. Missing support files?"

On Wed, Aug 17, 2022 at 3:09 PM Eric Younkin @.***> wrote:

Believe it means it can't find the grid files. Can you look in VDatum to see if all the grids called out in the pipeline string exist?

On Wed, Aug 17, 2022 at 2:12 PM jalland @.***> wrote:

Thanks Eric! Tingzhe Si sended me an older version of vdatum that works. However, I am still not able to get vyperdatum to work property. I'm getting an error when trying to run the example code: "Pipeline "+proj=pipeline +step +proj=vgridshift grids=core\xgeoid20b\conuspac.gtx +step +inv +proj=vgridshift grids=VAswchb11_8301\tss.gtx +step +proj=vgridshift grids=VAswchb11_8301\mllw.gtx" for transformation from "[[]]" to "[+proj=pipeline +step +proj=vgridshift grids=core\xgeoid20b\conuspac.gtx +step +inv +proj=vgridshift grids=VAswchb11_8301\tss.gtx +step +proj=vgridshift grids=VAswchb11_8301\mllw.gtx]" in region "VAswchb11_8301" was flagged as invalid. Missing support files?" and "No valid region found with the specified datum transformation. Unable to perform transformation"

Any idea why this may be?

— Reply to this email directly, view it on GitHub < https://github.com/noaa-ocs-hydrography/vyperdatum/issues/34#issuecomment-1218342781 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AOA2JUBEO7MBHWLL3SIEN5DVZUTPFANCNFSM56W46BYA

. You are receiving this because you commented.Message ID: @.***>

-- Eric Younkin Physical Scientist NOAA OCS, Hydrographic Systems and Technology Branch 1315 East-West Highway N/CS11, Room 6604 Silver Spring, MD 20910 Office: ‪(302) 751-0538‬ Cell: 828-331-8197

— Reply to this email directly, view it on GitHub https://github.com/noaa-ocs-hydrography/vyperdatum/issues/34#issuecomment-1218391110, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADZRZ2BWI57NPAHI7XRMAMLVZU2FPANCNFSM56W46BYA . You are receiving this because you authored the thread.Message ID: @.***>

ericgyounkin commented 1 year ago

@jalland Sorry for the delay on this, can you let me know the command you used and the version of Vdatum that you are using to get this message? I will try and replicate here.

ericgyounkin commented 1 year ago

@jalland in addition, I have added support for Vdatum 4.4.2 in vyperdatum 0.1.16 (see https://github.com/noaa-ocs-hydrography/vyperdatum/commit/a9aa34200983faafc54b1833a0bb9937c7647538)

jalland commented 1 year ago

vadtum version 4.4.1. I was following the example script: https://github.com/noaa-ocs-hydrography/vyperdatum

This line gave the error: vp.transform_points(6319, 'mllw', x, y, z=z)

jalland commented 1 year ago

Hi Eric - sorry for the late reply. I am just looking into this now. I am still getting the same error when trying your "Quickstart" script on Github. Would you be able to have a video call to potentially work out the issues?

Error: "Pipeline "+proj=pipeline +step +proj=vgridshift grids=core\xgeoid20b\conuspac.gtx +step +inv +proj=vgridshift grids=VAswchb11_8301\tss.gtx +step +proj=vgridshift grids=VAswchb11_8301\mllw.gtx" for transformation from "[[]]" to "[+proj=pipeline +step +proj=vgridshift grids=core\xgeoid20b\conuspac.gtx +step +inv +proj=vgridshift grids=VAswchb11_8301\tss.gtx +step +proj=vgridshift grids=VAswchb11_8301\mllw.gtx]" in region "VAswchb11_8301" was flagged as invalid. Missing support files?"

On Tue, Sep 20, 2022 at 3:19 PM Eric Younkin @.***> wrote:

@jalland https://github.com/jalland in addition, I have added support for Vdatum 4.4.2 in vyperdatum 0.1.16 (see a9aa342 https://github.com/noaa-ocs-hydrography/vyperdatum/commit/a9aa34200983faafc54b1833a0bb9937c7647538 )

— Reply to this email directly, view it on GitHub https://github.com/noaa-ocs-hydrography/vyperdatum/issues/34#issuecomment-1252802709, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADZRZ2BOP6ZHXGIDBALICWLV7IE4XANCNFSM56W46BYA . You are receiving this because you were mentioned.Message ID: @.***>