search

noaa-ocs-modeling / CoastalApp

CoastalApp will be deprecated. Please switch to https://github.com/oceanmodeling/ufs-coastal . CoastalApp is a NUOPC application implemented following UFS best practices to couple coastal ocean models and other domains (Sea Ice, Atmosphere, Wave, Inland Hydrology, ...)
https://github.com/oceanmodeling/ufs-coastal
Creative Commons Zero v1.0 Universal
13 stars 30 forks source link

Running ADCIRC-WW3 without currents for WW3 #144

Closed sarriegi closed 1 year ago

sarriegi commented 1 year ago

Hello, I thought that running ADCIRC-WW3 with the currents disabled for WW3 would be simple just by turning the the corresponding flag in the ww3_multi file from 'CPL:native' to 'no'. However, when I did that I got this error: error I thought that another way to do this would be to go to the file that is responsible for the passing of the currents and multiply the u and v components of the currents with zero before they are passed to WW3. If this a correct way to do this, where this should be done? My guess is in ADCIRC/thirdparty/nuopc/adc_cap.F90, in the lines below: adc_cap Is this correct? If yes, there are two same lines for the u and two same lines for the v component, I guess I will have to multiply by zero all 4 of them? @moghimis @pvelissariou1

Angelos

pvelissariou1 commented 1 year ago

Aggelos hi,

I'll come back to you in a couple of days with updates.

Takis

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Mon, Oct 31, 2022 at 11:01 PM sarriegi @.***> wrote:

Hello, I thought that running ADCIRC-WW3 with the currents disabled for WW3 would be simple just by turning the the corresponding flag in the ww3_multi file from 'CPL:native' to 'no'. However, when I did that I got this error: [image: error] https://user-images.githubusercontent.com/77630268/199153425-c0d79ad7-ae32-48a7-9e0d-28c09ddd1db0.png I thought that another way to do this would be to go to the file that is responsible for the passing of the currents and multiply the u and v components of the currents with zero before they are passed to WW3. If this a correct way to do this, where this should be done? My guess is in ADCIRC/thirdparty/nuopc/adc_cap.F90, in the lines below: [image: adc_cap] https://user-images.githubusercontent.com/77630268/199155513-a1292c45-92ee-4c40-85a6-70dd7cc8956b.png Is this correct? If yes, there are two same lines for the u and two same lines for the v component, I guess I will have to multiply by zero all 4 of them? @moghimis https://github.com/moghimis @pvelissariou1 https://github.com/pvelissariou1

Angelos

— Reply to this email directly, view it on GitHub https://github.com/noaa-ocs-modeling/CoastalApp/issues/144, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TP44LZF2CTOSCOTRHM3WGCIYXANCNFSM6AAAAAARTWAE6U . You are receiving this because you were mentioned.Message ID: @.***>

pvelissariou1 commented 1 year ago

@sarriegi Hi Angelos,

For the time being, please try to use the branch develop_build from CoastalApp. A lot of things have been updated including WaveWatch III fixes. Use: git clone https://github.com/noaa-ocs-modeling/CoastalApp.git -b develop_build

Option 1: You may run the build script with a pre-built ParMetis library as: PARMETISHOME=location_of_installed_parmetis ./build.sh --compiler intel --component "atmesh adcirc ww3" --platform YOUR_PLATFORM

Option 2: Run the scripts/download_parmetis.sh to fetch the ParMETIS sources. The sources will be stored in the thirdparty_open folder Next run the build script as: ./build.sh --compiler intel --component "atmesh adcirc ww3" --platform YOUR_PLATFORM --tp parmetis to build CoastalApp with the native parmetis.

WaveWatch III in CoastalApp uses the PDLIB switch (thus parmetis) by default. To compile without PDLIB, just remove this switch from the WW3/model/esmf/switch file and compile CoastalApp as described above. Make sure you do a clean compilation, that is clean all generated objects from a previous compilation by running: ./build.sh --compiler intel --component "atmesh adcirc ww3" --platform YOUR_PLATFORM --tp parmetis --clean 3

Please let me know if the above work for you.

I'll be on annual leave from Monday to Wednesday.

Takis

sarriegi commented 1 year ago

Thank you @pvelissariou1 ! The command git clone https://github.com/noaa-ocs-modeling/CoastalApp.git -b develop_build doesn't seem to work properly for me. There is a folder called 'CoastalApp' being generated, with all the sub-directories like 'WW3', 'ADCIRC', 'NEMS' etc inside it, but all of these sub-directories are completely empty. Do you know what the problem might be?

Angelos

@saeed-moghimi-noaa

sarriegi commented 1 year ago

@pvelissariou1 @saeed-moghimi-noaa I added the --recurse-submodules option and I was able to download the full version

Angelos

pvelissariou1 commented 1 year ago

Thank you Angelos, I forgot to include it. Please let us know how your tests with WaveWatch III go.

Takis

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Sun, Nov 13, 2022 at 11:13 AM sarriegi @.***> wrote:

@pvelissariou1 https://github.com/pvelissariou1 @saeed-moghimi-noaa https://github.com/saeed-moghimi-noaa I added the --recurse-submodules option and I was able to download the full version

Angelos

— Reply to this email directly, view it on GitHub https://github.com/noaa-ocs-modeling/CoastalApp/issues/144#issuecomment-1312779107, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TPZ2QVYNUIFZDADT5MDWIEOTZANCNFSM6AAAAAARTWAE6U . You are receiving this because you were mentioned.Message ID: @.***>

sarriegi commented 1 year ago

Hi @pvelissariou1 , I am facing some issues with the compilation of ADCIRC. With the same environment, cmplrflags.mk file and command as I was using in the past for previous versions, I get the following errors: image These errors appear while trying to compile padcirc. The compilations of adcprep or adcirc finish without erros. Also WW3 compiles without errors. Do you know what might be the problem?

Angelos

sarriegi commented 1 year ago

I figured it out after all! @pvelissariou1

Angelos

pvelissariou1 commented 1 year ago

Angelos, likely you didn't clone the very latest version of develop_build branch. The problem was with the missing flag -DHAVE_MPI_MOD in ADCIRC compiler flags file. Great, you figured this out.

Takis

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Sun, Nov 13, 2022 at 9:36 PM sarriegi @.***> wrote:

I figured it out after all! @pvelissariou1 https://github.com/pvelissariou1

Angelos

— Reply to this email directly, view it on GitHub https://github.com/noaa-ocs-modeling/CoastalApp/issues/144#issuecomment-1313050946, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TP2GAUPIQXMS4I6CNADWIGXUFANCNFSM6AAAAAARTWAE6U . You are receiving this because you were mentioned.Message ID: @.***>

pvelissariou1 commented 1 year ago

not an issue anymore