noaa-ocs-modeling / CoastalApp

CoastalApp will be deprecated. Please switch to https://github.com/oceanmodeling/ufs-coastal . CoastalApp is a NUOPC application implemented following UFS best practices to couple coastal ocean models and other domains (Sea Ice, Atmosphere, Wave, Inland Hydrology, ...)
https://github.com/oceanmodeling/ufs-coastal
Creative Commons Zero v1.0 Universal
13 stars 32 forks source link

UFS-Coastal/FVCOM Inclusion: Development/Testing/Consulation #177

Open pvelissariou1 opened 1 year ago

pvelissariou1 commented 1 year ago

Support of inclusion of FVCOM into UFS-Coastal. Three tasks are defined for this project:

Related Issues: CoastalApp test suite #150

pvelissariou1 commented 1 year ago

Submitted a PR to FVCOM repo for the updates to the source tree. On 06/22/2023 the PR will be reviewed and merged into the main branch. FVCOM compiles as expected within CoastalApp as expected, tests also passed. Jianhua is working on a barotropic test case for ATMESH+FVCOM upon my request. A 2D case ATMESH+FVCOM+WW3 will follow.

saeed-moghimi-noaa commented 1 year ago

Please update

saeed-moghimi-noaa commented 10 months ago

@pvelissariou1 @janahaddad

Hi Takis,

Please make sure to coordinate with the project team here before accepting any tasks from model developers specific to models and not directly related to the UFS-Coastal.

Again I want to repeat the process in which we should work with the Model Developers in general:

We at the NOS Storm Surge Modeling Team in collaboration with NCAR team will continue supporting integration of new developments and upgrades of FVCOM and other models (model, cap, ....) that are shared with us into the UFS-Coastal code base through:

  1. github pull requests
  2. by providing appropriate Regression Tests (RT).
pvelissariou1 commented 10 months ago

Thanks @saeed-moghimi-noaa I totally agree. There are occassions though that we might need to provide some additional support in order to move forward in UFS-Coastal, as in the case of the julian library in FVCOM. I think I have already provided enough consultation to FVCOM folks so far, they now need to provide us with the required RTs to go to the next stage.

pvelissariou1 commented 10 months ago

FVCOM in UFS-Coastal is on hold at this moment. Waiting from the developers for:

  1. Fix the issue with the FVCOM required libraries (Julian). They need to incorporate the library into the FVCOM source os in the build process
  2. Supply a 2D test case for FVCOM coupled with WW3

Notes:

  1. The sources of WW3 should not be modified, instead need to submit a PR to WW3 developers for the required changes/modifications. In general, WW3 needs to export additional wave variables necessary to calculate the 3D wave induced terms in the various ocean models (we should have a discussion about this)
  2. FVCOM's NUOPC cap needs cleanup, some rewrtting and improvements to support both 2D and 3D calculations
pvelissariou1 commented 6 months ago

Meeting minutes (Fwd: FVCOM Development Tag up Meeting, March 20, 2024) (From: Zizang Yang)

Please find below a brief summary of today's FVCOM Development Tag-up Meeting: