search

noaa-ocs-modeling / CoupledModelDriver

coupled model configuration generation
https://CoupledModelDriver.readthedocs.io
Creative Commons Zero v1.0 Universal
4 stars 3 forks source link

change `TimestepForcingJSON`'s `modeled_timestep` to be `interval` #118

Closed ghost closed 3 years ago

ghost commented 3 years ago

fixes #117

saeed-moghimi-noaa commented 3 years ago

@zacharyburnettNOAA

I suggest to use a more descriptive variable name like:

ForcingTimeStep or ForcingInterval

ghost commented 3 years ago

@zacharyburnettNOAA

I suggest to use a more descriptive variable name like:

ForcingTimeStep or ForcingInterval

I thought about that, but it is already in a ForcingJSON object, or in a configure_atmesh.json or configure_ww3data.json file, so I figure it would be redundant as you know which file you are looking in. The full name in code is ForcingJSON['interval']

I was thinking of making it read_interval because that is the interval at which it is read by the model, in modeled time