search

noaa-ocs-modeling / CoupledModelDriver

coupled model configuration generation
https://CoupledModelDriver.readthedocs.io
Creative Commons Zero v1.0 Universal
4 stars 3 forks source link

values in `configure_slurm.json` are overridden by platform defaults when generating configuation #122

Closed ghost closed 3 years ago

ghost commented 3 years ago

@zacharyburnettNOAA Almost got the generate_adcirc for this setup working on my system. I kept the platform option to "HERA" in configure_modeldriver.jsonsince also slurm. But then I specified my account in configure_slurm.json but this was overwritten to coastal in the job scripts when ran generate_adcirc. Otherwise everything seems oK.

I wonder, what is the platform "HERA" really doing? Is it necessary if we can specify the run options in configure_slurm? Where would I edit the platform in coupledmodeldriver to make sure account is set to my one in job scripts?

That's a good point, I think the platform parameter is a holdover from before I had configure_slurm.json. It uses these values as default: https://github.com/noaa-ocs-modeling/CoupledModelDriver/blob/02fccc8be24c96f545d26d7c7efcacd5dfe8fbe7/coupledmodeldriver/platforms.py#L5-L12

    HERA = {
        'source_filename': '/scratch2/COASTAL/coastal/save/shared/repositories/ADC-WW3-NWM-NEMS/modulefiles/envmodules_intel.hera',
        'processors_per_node': 40,
        'launcher': 'srun',
        'uses_slurm': True,
        'slurm_account': 'coastal',
        'default_partition': None,
    }

It must be messing up and overriding the values in configure_slurm.json with the default values. I'll take a look at it.

Originally posted by @zacharyburnettNOAA in https://github.com/noaa-ocs-modeling/EnsemblePerturbation/issues/40#issuecomment-910179433