search

noaa-ocs-modeling / CoupledModelDriver

coupled model configuration generation
https://CoupledModelDriver.readthedocs.io
Creative Commons Zero v1.0 Universal
4 stars 3 forks source link

Add best track forcing setup support for SCHISM model #139

Closed SorooshMani-NOAA closed 2 years ago

SorooshMani-NOAA commented 2 years ago

Using best track forcing implementation in pyschism setup SCHISM model with nhc b-deck forcing

SorooshMani-NOAA commented 2 years ago

@zacharyburnett, when you have time can you please see if you see any red flags for merging these changes? Thanks

SorooshMani-NOAA commented 2 years ago

@zacharyburnett I was also wondering if it would be OK for me to go ahead and publish a new version of this for the addition of basic schism support?

SorooshMani-NOAA commented 2 years ago

Thanks for reviewing. I think it makes things easier to reuse the relevant names/attributes as much as we can between different solvers setup.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 81.42857% with 13 lines in your changes missing coverage. Please review.

Project coverage is 64.38%. Comparing base (7f0ae46) to head (8241c3e). Report is 93 commits behind head on main.

Files Patch % Lines
coupledmodeldriver/configure/forcings/base.py 56.00% 11 Missing :warning:
coupledmodeldriver/generate/schism/base.py 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #139 +/- ## ========================================== + Coverage 64.01% 64.38% +0.37% ========================================== Files 35 35 Lines 3738 3805 +67 ========================================== + Hits 2393 2450 +57 - Misses 1345 1355 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.