search

noaa-ocs-modeling / CoupledModelDriver

coupled model configuration generation
https://CoupledModelDriver.readthedocs.io
Creative Commons Zero v1.0 Universal
4 stars 3 forks source link

Issue with Publishing Package due to GitHub dependency #140

Closed SorooshMani-NOAA closed 2 years ago

SorooshMani-NOAA commented 2 years ago

@zacharyburnett, when I tried to publish v1.5, I got this error: https://github.com/noaa-ocs-modeling/CoupledModelDriver/runs/6696377333

It seems that we cannot include a direct git dependency for building the package for publishing:

Publishing coupledmodeldriver (1.5.0) to PyPI
 - Uploading coupledmodeldriver-1.5.0-py3-none-any.whl 0%
 - Uploading coupledmodeldriver-1.5.0-py3-none-any.whl 1[8](https://github.com/noaa-ocs-modeling/CoupledModelDriver/runs/6696377333?check_suite_focus=true#step:7:9)%
 - Uploading coupledmodeldriver-1.5.0-py3-none-any.whl [10](https://github.com/noaa-ocs-modeling/CoupledModelDriver/runs/6696377333?check_suite_focus=true#step:7:11)0%

  UploadError

  HTTP Error 400: Invalid value for requires_dist. Error: Can't have direct dependency: 'pyschism @ git+https://github.com/schism-dev/pyschism.git@main'

The problem is pyschism has not been published since September last year, and there has been significant updates made in the main branch. Maybe the easy approach to solve this is to just remove the pyschism dependency from pyproject.toml file and explicitly install it for tests. Also ask the users to install it (?). Though this last part would be very messy!

What do you think?

SorooshMani-NOAA commented 2 years ago

relevant to the issue: https://peps.python.org/pep-0440/#direct-references

SorooshMani-NOAA commented 2 years ago

I started working with VIMS team to get pyschism published on PyPI, it seems that they don't have any problems with publishing.