noaa-ocs-modeling / CoupledModelDriver

coupled model configuration generation
https://CoupledModelDriver.readthedocs.io
Creative Commons Zero v1.0 Universal
4 stars 3 forks source link

shapley implementation for track perturbation #88

Closed saeed-moghimi-noaa closed 3 years ago

saeed-moghimi-noaa commented 3 years ago

shapley implementation

WPringle commented 3 years ago

See https://github.com/WPringle/Storm-Surge-Mesh-Subsetting/commit/50cb7f9f5e7dcd128bce8796884e019a2a4bdcfc for the along-track perturbation work.

WPringle commented 3 years ago

@zacharyburnettNOAA @saeed-moghimi-noaa Example for along-track perturbed Hurricane Florence 2018: Along_track_compare

WPringle commented 3 years ago

@zacharyburnettNOAA Note also a change in write fort.22 routine of adcircpy in the PR. I want it to "round" the floats instead of change to "int". (e.g., I want 34.67N to be 34.7N not 34.6N). But I am getting a conflict with a recent change you made to use a "convert_value" function.

WPringle commented 3 years ago

@zacharyburnettNOAA @saeed-moghimi-noaa I also want to mention that I changed the Rmax behavior to go in the opposite direction. Previously it was adding the error but I think it should subtract the error.

Example: A storm with small forecasted Rmax is more likely to be under predicted in size, i.e., the error in Rmax will be negative most of the time. So for perturbation, most of the time we want to increase the size of the small storm, therefore need to subtract the negative error.

ghost commented 3 years ago

https://github.com/JaimeCalzadaNOAA/adcircpy/pull/60 is now merged

WPringle commented 3 years ago

See this commit for the cross-track perturbation implementation: https://github.com/WPringle/Storm-Surge-Mesh-Subsetting/commit/239421a05bc8398e45684e005efcb30fdeae7822

Example: Cross-track_compare

saeed-moghimi-noaa commented 3 years ago

Looks very good @WPringle

ghost commented 3 years ago

wow, very good work!