search

noaa-ocs-modeling / EnsemblePerturbation

perturbation of coupled model input over a space of input variables
https://ensembleperturbation.readthedocs.io
Creative Commons Zero v1.0 Universal
7 stars 3 forks source link

Fix plotting issue caused by a recent PR #100

Closed SorooshMani-NOAA closed 1 year ago

SorooshMani-NOAA commented 1 year ago

The axis created at

https://github.com/noaa-ocs-modeling/EnsemblePerturbation/blob/189f323e78fc98c154552267c05cc0ce82e499dc/ensembleperturbation/plotting/surrogate.py#L295-L310

is not initialized by a projection, so it doesn't support add_feature, hence the following code added in a recent change breaks the code when trying to plot sensitivities using the example code in the repo.

https://github.com/noaa-ocs-modeling/EnsemblePerturbation/blob/189f323e78fc98c154552267c05cc0ce82e499dc/ensembleperturbation/plotting/nodes.py#L222-L225

@WPringle did you miss adding any other changes in #93? For example any change in surrogate.py's initialization of the axis, etc.?

SorooshMani-NOAA commented 1 year ago

@WPringle can I safely uncomment the projection at https://github.com/noaa-ocs-modeling/EnsemblePerturbation/blob/189f323e78fc98c154552267c05cc0ce82e499dc/ensembleperturbation/plotting/surrogate.py#L295-L297 or not?

WPringle commented 1 year ago

@SorooshMani-NOAA Sure. It make have been that I called it after having initialized the projection outside of the function, but suggest to uncomment it.