Closed SorooshMani-NOAA closed 10 months ago
@WPringle I think the failed tests are due to wrong references. I'll do more testing on all the 3 storms from NHC, but can you check if you see anything wrong with the changes I made?
@SorooshMani-NOAA Thanks for fix! Although it's strange since alpha
already looks like it should be positive always and reason for not needing abs() value.
Although it's strange since alpha already looks like it should be positive
@WPringle I actually realized that later, but just wanted to be extra sure, the main fix was related to how 1 dim arrays where being incorrectly mean
ed or diff
ed
Although it's strange since alpha already looks like it should be positive
@WPringle I actually realized that later, but just wanted to be extra sure, the main fix was related to how 1 dim arrays where being incorrectly
mean
ed ordiff
ed
oh right, gotcha. think everything looks good
Attention: Patch coverage is 0%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 21.29%. Comparing base (
eede830
) to head (5b7c4e4
). Report is 14 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
ensembleperturbation/perturbation/atcf.py | 0.00% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes #118