search

noaa-ocs-modeling / EnsemblePerturbation

perturbation of coupled model input over a space of input variables
https://ensembleperturbation.readthedocs.io
Creative Commons Zero v1.0 Universal
7 stars 3 forks source link

Use `maxele.gr3` for maximum elevation results #124

Open SorooshMani-NOAA opened 7 months ago

SorooshMani-NOAA commented 7 months ago

Currently the out_2d*.nc file is used to get the max-elevation dataset for analysis: https://github.com/noaa-ocs-modeling/EnsemblePerturbation/blob/1fbaf14d44b5a1991d97a2451a92a72f7c069bac/ensembleperturbation/parsing/schism.py#L719-L726

I think the main reason behind that is the missing maximum elevation time in the gr3 file. Since the timing data is not currently being used, maybe it makes more sense to just use the maxelev.gr3 values instead. out2d_* is output is controlled by output step, while maxelev.gr3 is the actual maximum.

Just FYI @FariborzDaneshvar-NOAA

FariborzDaneshvar-NOAA commented 7 months ago

@SorooshMani-NOAA thanks for looking into this. Based on my experience working with outliers of with/out NWM, elevations from maxelev.gr3 could be much higher than out2d_*.nc, and the reason is that the first one includes the entire time period and might include noises from the earlier times! Here is one example: https://github.com/noaa-ocs-modeling/SurgeTeamCoordination/issues/115#issuecomment-1740210537