noaa-ocs-modeling / EnsemblePerturbation

perturbation of coupled model input over a space of input variables
https://ensembleperturbation.readthedocs.io
Creative Commons Zero v1.0 Universal
7 stars 3 forks source link

Add probability field calc and plots #127

Closed SorooshMani-NOAA closed 9 months ago

codecov-commenter commented 9 months ago

Codecov Report

Attention: 89 lines in your changes are missing coverage. Please review.

Comparison is base (1fbaf14) 21.29% compared to head (830ede3) 20.80%. Report is 1 commits behind head on main.

Files Patch % Lines
...rturbation/uncertainty_quantification/surrogate.py 0.00% 55 Missing :warning:
ensembleperturbation/plotting/surrogate.py 0.00% 33 Missing :warning:
ensembleperturbation/parsing/schism.py 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #127 +/- ## ========================================== - Coverage 21.29% 20.80% -0.49% ========================================== Files 28 28 Lines 3762 3850 +88 ========================================== Hits 801 801 - Misses 2961 3049 +88 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SorooshMani-NOAA commented 9 months ago

This is an example of its use. I got better result on a different dataset, but I don't have it now!

image

SorooshMani-NOAA commented 9 months ago

@WPringle swapping the order of set small elev to null and set null to depth for model calculation, (i.e. https://github.com/noaa-ocs-modeling/EnsemblePerturbation/blob/4d82917f3e1fcce456fd7b5a587da07b7b8658e7/ensembleperturbation/uncertainty_quantification/surrogate.py#L676-L678 and https://github.com/noaa-ocs-modeling/EnsemblePerturbation/blob/4d82917f3e1fcce456fd7b5a587da07b7b8658e7/ensembleperturbation/uncertainty_quantification/surrogate.py#L679-L679 ) resulted in these plots: image

I think it might make more sense to keep the swapped version. What do you think?

SorooshMani-NOAA commented 9 months ago

These are the first couple of probability fields for the 30 member Florence run with OFCL track (past forecast, no NWM)

image