search

noaa-ocs-modeling / EnsemblePerturbation

perturbation of coupled model input over a space of input variables
https://ensembleperturbation.readthedocs.io
Creative Commons Zero v1.0 Universal
7 stars 3 forks source link

Bug fix/gahm converge #161

Closed WPringle closed 3 weeks ago

WPringle commented 3 weeks ago

It was found to be failing for a Hurricane Idalia test: https://github.com/oceanmodeling/ondemand-storm-workflow/issues/75

Fixed the determination of no possible solution by including the rfo2 term.

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 25.50%. Comparing base (1e98e44) to head (9bd9557).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #161 +/- ## ======================================= Coverage 25.50% 25.50% ======================================= Files 29 29 Lines 4027 4027 ======================================= Hits 1027 1027 Misses 3000 3000 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SorooshMani-NOAA commented 3 weeks ago

@WPringle thanks for working on this. Should I go ahead and merge this or do you have more stuff to add?

WPringle commented 3 weeks ago

@WPringle thanks for working on this. Should I go ahead and merge this or do you have more stuff to add?

It is is good to go, so please merge it in thank you.