search

noaa-ocs-modeling / EnsemblePerturbation

perturbation of coupled model input over a space of input variables
https://ensembleperturbation.readthedocs.io
Creative Commons Zero v1.0 Universal
7 stars 3 forks source link

add python script for ensemble vortex generation #21

Closed ghost closed 3 years ago

ghost commented 3 years ago

draft pull request; put discussion about besttrack perturbation here

WPringle commented 3 years ago

Great, I am happy with this here. Maybe it will be easy enough just to have this as part of this repository for good.

Do you want to keep working on this to develop different options and modularize this in a single PR?

WPringle commented 3 years ago

For starters I think I would like to extract "best_track_forcing" class from adcircy and make into some kind of "ATCF" or "vortex" class here.

ghost commented 3 years ago

Do you want to keep working on this to develop different options and modularize this in a single PR?

For starters I think I would like to extract "best_track_forcing" class from adcircy and make into some kind of "ATCF" or "vortex" class here.

yes, that's a good idea. Lets continue working on this branch and make it a full-fledged perturber

ghost commented 3 years ago

@WPringle I've also started using pint to handle unit conversions and multiplications between different units.

WPringle commented 3 years ago

@WPringle I've also started using pint to handle unit conversions and multiplications between different units.

Yeah that's pretty cool, thanks!

WPringle commented 3 years ago

@zacharyburnettNOAA I have a commit where I copied over besttrackforcing from adcircpy into own module in this repository and removed some adcirc related things. The test seemed to go through ok (amazingly). I was denied when try to push to this branch. What's best to do this? Make PR from a fork of mine to this branch?

ghost commented 3 years ago

@zacharyburnettNOAA I have a commit where I copied over besttrackforcing from adcircpy into own module in this repository and removed some adcirc related things. The test seemed to go through ok (amazingly). I was denied when try to push to this branch. What's best to do this? Make PR from a fork of mine to this branch?

Yes, for now make a fork + PR, until we can add you to the organization