noaa-ocs-modeling / EnsemblePerturbation

perturbation of coupled model input over a space of input variables
https://ensembleperturbation.readthedocs.io
Creative Commons Zero v1.0 Universal
7 stars 3 forks source link

fix track perturbation (all track files are identical) #33

Closed ghost closed 3 years ago

ghost commented 3 years ago

@WPringle noticed that the generated tracks are identical, so something is going wrong in the perturbation currently

WPringle commented 3 years ago

Ah yes I see that this is the case even for the test reference data in this repository. Didn't check that before. Was definitely working on the original repository though...

ghost commented 3 years ago

looks like the problem is here: https://github.com/noaa-ocs-modeling/EnsemblePerturbation/blob/f554e292e214422040818304478baa5fc9d1fc3c/ensembleperturbation/perturbation/atcf.py#L828

there is no ._df property anymore, I renamed it to be .data to be more descriptive