Closed ghost closed 2 years ago
:exclamation: No coverage uploaded for pull request base (
feature/regression_selection@7912f5c
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## feature/regression_selection #79 +/- ##
===============================================================
Coverage ? 31.12%
===============================================================
Files ? 26
Lines ? 2940
Branches ? 0
===============================================================
Hits ? 915
Misses ? 2025
Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7912f5c...4c86d52. Read the comment docs.
@zacharyburnettNOAA Can make sure the tests are all working as we upgrade the version, and we need to work out how to better treat the advisories (from the a
deck) of the storms. All the advisories are squashed together but we need to work out a way to separate them for each individual forecast.
@zacharyburnettNOAA Can make sure the tests are all working as we upgrade the version, and we need to work out how to better treat the advisories (from the
a
deck) of the storms. All the advisories are squashed together but we need to work out a way to separate them for each individual forecast.
Ok, that's easily done by iterating over the 'record_type'
field, which is 'BEST'
, 'OFCL'
, 'CARQ'
, etc.. You can do that in pandas by using track.data.groupby('record_type
)`
But you are right, we need to add native handling of the record types. I added functionality for that in the .linestrings
method (to separate into multiple line strings for each advisory track) but I don't think it is elsewhere in the code
use new method names and ATCF reading functionality from
stormevents
, and apply new improved CI workflow that fixes running tests