Closed WPringle closed 1 year ago
Merging #97 (3a938f0) into main (828f155) will increase coverage by
0.31%
. The diff coverage is100.00%
.:exclamation: Current head 3a938f0 differs from pull request most recent head d026d25. Consider uploading reports for the commit d026d25 to get more accurate results
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 19.26% 19.57% +0.31%
==========================================
Files 26 27 +1
Lines 3691 3703 +12
==========================================
+ Hits 711 725 +14
+ Misses 2980 2978 -2
Impacted Files | Coverage Δ | |
---|---|---|
ensembleperturbation/perturbation/atcf.py | 50.37% <ø> (+0.30%) |
:arrow_up: |
tests/test_advisory_ensemble.py | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@SorooshMani-NOAA Thanks, I'm looking for values that are 0 to stay 0, if not then add in the new value. The way it is written we need the inverse of that so != 0
instead of >=1
.
I think we could add a test for the perturbation of an existing a
file_deck advisory (forecast) ATCF file. Do you want me add that in?
@WPringle thanks for the explanation.
Yes please, if it's not too much trouble, can you please add the test?
@SorooshMani-NOAA Added the perturbation of existing advisory file test.
@WPringle thanks, looks good. Should I merge it or is there anything else that you'd like to add/modify in this PR?
@SorooshMani-NOAA I think it is good to go! Don't have anything more to add.
advisories
and/orfile_deck
inperturb_tracks
when reading from existing file.lower_bounds
setting that would set the value to zero instead when the perturbed value would be <1 due to logic intended to deal with zeros/null values. Just use != 0.