noaa-onms / cinms

Channel Islands National Marine Sanctuary
https://noaa-onms.github.io/cinms
MIT License
3 stars 1 forks source link

error in nms4r function map_nms_sites #67

Closed superjai closed 3 years ago

superjai commented 3 years ago

@bbest There is an error in the nms4r function map_nms_sites. I flagged it with your name in the code itself and here is the link. It isn't a problem at the moment, as it only comes up if certain files are missing (which won't be the case for CINMS - but might be for other regions). Here is the problem reprinted below

    # BEN: note that the following line of code will fail because raw_csv and sites_csv
    # aren't defined anywhere
    if (!file.exists(sites_csv)) make_sites_csv(raw_csv, sites_csv)
bbest commented 3 years ago

This is not fixable in the near term since we don't have the ability to publicly share original MARINe data, but we can caveat this in a Vignette for the nms4r package and in README for the CINMS repo.

bbest commented 3 years ago

Let's close this and describe private data aspects of MARINe rocky intertidal in a vignette #69