search

noaa-onms / cinms

Channel Islands National Marine Sanctuary
https://noaa-onms.github.io/cinms
MIT License
3 stars 1 forks source link

remote files not loading #76

Closed superjai closed 3 years ago

superjai commented 3 years ago

Hey @bbest - I am having an issue with rendering modal windows when the css and javascript files are not local. I have made an "authoritative" copy of the javascript and css used here: https://github.com/marinebon/infographiq/tree/master/libs

However, when pointing to there, it isn't found.

bbest commented 3 years ago

Do we have the files in the proper place, eg in the inst/ (see https://r-pkgs.org/inst.html)?

Two goals we're trying to achieve:

  1. Authoritative version of the JavaScript.
  2. R package of common functions to use.
bbest commented 3 years ago

Let's see how the pros do it, like with rstudio/dygraphs?

A few things worthy of note:

  1. All files not strictly a part of the R package system are in the inst/ folder.
  2. Use of tags to manage multiple versions, with NEWS to summarize changes (ie issues) resolved between tagged releases.
  3. The files in inst/ are actually organized as an htmlwidget, which enables JavaScript functionality in three awesome contexts: 1) RStudio, 2) Rmarkdown, and 3) Shiny. It'd be awesome to embrace this someday.