pre-demonstration fixes

bbest commented 3 years ago

From Jenn Brown...

Going through my demo slides and outline. As of 6:30 PM Tues - the following issues need resolving:

[x] 1) Infographics: new captions and caption changes that were input this morning for sights and sounds in CINMS, FKNMS and HIHW are not appearing on website
[x] 2) CINMS 'Where did we listen?' - sound propagation map not loading
[x] 3) FKNMS 'Where did we listen?' - changes Carrie made to the locations tab are not reflected on the interactive map
[x] 4) HIHWNMS infographic: sperm whales and smaller boats are in the list but the icons are not on the infographic
[x] 5) Sounds pull down menu: many clips are listed for Animals, Human-made, and Physical, but they are not all showing up on the All Sounds page. Also, when on the All Sounds page, I am not able to navigate to any other page except for the home page or access other pull down menus
[x] 6) when on the All Stories page, I am not able to navigate to any other page except for the home page or access other pull down menus
[x] 7) The detection graphs are not showing up for CINMS humpback whales.
[x] 8) Only the daily detection graph is showing up for CINMS vessels (either container ship or smaller vessels)

bbest commented 3 years ago

[x] 2) CINMS 'Where did we listen?' - sound propagation map not loading

CINMS > "Where did we listen?" tab was showing:

## Error in curl::curl_fetch_memory(url, handle = handle) : 
##   Error in the HTTP2 framing layer

After running:

https://github.com/noaa-onms/sanctsound/blob/e942d1b35594966c9903be1f6f8540692e9fe648/draft/_sanctuary_template.Rmd#L70-L73

Ran this to update the image file:

glink <- tbl_listen %>% 
  filter(file_type == "propagation") %>% 
  pull(gdrive_shareable_link)
gdrive2path(glink, relative_pfx = "")

bbest commented 3 years ago

[x] 4) HIHWNMS infographic: sperm whales and smaller boats are in the list but the icons are not on the infographic
+ icons: sperm-whales, smaller-boats

bbest commented 3 years ago

[x] 6) when on the All Stories page, I am not able to navigate to any other page except for the home page or access other pull down menus

This appears to have gotten fixed with commit https://github.com/noaa-onms/sanctsound/commit/f42191d8191a98f10a2985c420cb204af18f924e. Previously when I updated the sounds.html, I noticed it was missing jquery from when I was trying to clean up old versions. Re-knitting fixed this.

bbest commented 3 years ago

[x] 7) The detection graphs are not showing up for CINMS humpback whales.

These rows in modals sheet of sanctsound website content got tab_name values changed from "Daily patterns" to "Time series".

Updated _modal_template.Rmd to using "Time series" so now has the extra tab:

Applied to all tab_name == "Time series": Container Ships, Humpback whales, Smaller Vessels (all in CINMS)

[x] 8) Only the daily detection graph is showing up for CINMS vessels (either container ship or smaller vessels)

bbest commented 3 years ago

[x] 1) Infographics: new captions and caption changes that were input this morning for sights and sounds in CINMS, FKNMS and HIHW are not appearing on website

Reran render_site.R with redo_modals <- T and updated the following modals in commit https://github.com/noaa-onms/sanctsound/commit/6a85b97aa7c8cf5b6dd2369e9241dae4ba2f6234:

bbest commented 3 years ago

From Jenn:

Hi Carrie and Ben,I just restarted my system and see the same fixes and remaining issues that Carrie provided above.My top priority to fix before the presentation are:

[x] 2) I still see an error on the CINMS Where did we listen page (issue 2))
[x] 7)/8) I only see the timeseries tab of the detections. There should also be 'Daily patterns' for CINMS vessels and 'Monthly patterns' for CINMS vessels and CINMS humpback (issue #7/8-ish)

These are key places where we are showing how we will be incorporating house products in the foyer

From Carrie: Hi Ben, I know we're running against the clock here and I truly appreciate all your efforts to fix these bugs.

[x] 2) I still see an error on the CINMS Where did we listen page (issue 2)
[x] 3) The locations on the FKNMS Where did we listen page show FK01, FK02, FK03, and FK04. FK04 should be omitted per Column F on the Locations tab of your spreadsheet. (issue 3))
[x] 6) The sound inventory still does not reflect all sounds available, only one per category shows up on the All Sounds page (issue 6))
[x] 7)/8) I only see the timeseries tab of the detections. There should also be 'Daily patterns' for CINMS vessels and 'Monthly patterns' for CINMS vessels and CINMS humpback (issue 7)/8)-ish)

PLEASE let me know if I'm just not seeing your latest and greatest work. I cleared my cache but there is still a strong chance that the source of the above is user error.

bbest commented 3 years ago

[x] 2) I still see an error on the CINMS Where did we listen page (issue 2))

Reran in commit https://github.com/noaa-onms/sanctsound/commit/dbf81c538122d4f43bd2ea84845860c674cad170 to produce working version:

https://sanctsound.ioos.us/draft/s_cinms.html

bbest commented 3 years ago

[x] 7)/8) I only see the timeseries tab of the detections. There should also be 'Daily patterns' for CINMS vessels and 'Monthly patterns' for CINMS vessels and CINMS humpback (issue #7/8-ish)

These work for me. Please try refreshing the page in your browser (usually F5 or Shift + Reload to hard refresh) after directly visiting:

cinms_container-ships

cinms_container-ships:

cinms_humpback-whales

cinms_humpback-whales:

cinms_smaller-vessels

cinms_smaller-vessels:

bbest commented 3 years ago

[x] 3) The locations on the FKNMS Where did we listen page show FK01, FK02, FK03, and FK04. FK04 should be omitted per Column F on the Locations tab of your spreadsheet. (issue 3))

Fixed in commit locations.use_for_map -> map: Where did we listen?, eg:

Florida Keys National Marine Sanctuary

BEFORE

AFTER

bbest commented 3 years ago

[x] 6) The sound inventory still does not reflect all sounds available, only one per category shows up on the All Sounds page (issue 6))

fixed newlines in md output for sounds.html #5 6) · noaa-onms/sanctsound@12becdc

BEFORE

AFTER

bbest commented 3 years ago

[x] 7)/8) I only see the timeseries tab of the detections. There should also be 'Daily patterns' for CINMS vessels and 'Monthly patterns' for CINMS vessels and CINMS humpback (issue 7)/8)-ish)

Fixed "Monthly patterns" in _modal_template.Rmd in commit https://github.com/noaa-onms/sanctsound/commit/feda171883f02b82424c899ef68a04b7e6b169f6 & changed values for tab_name = "Monthly pattern" to "Monthly patterns" in sanctsound website content - Google Sheets for CINMS:

Container Ships
Smaller Vessels

Please visit and hard refresh:

BEFORE

cinms_humpback-whales

AFTER

cinms_humpback-whales

bbest commented 3 years ago

[ ] Jenn: I don't know why your fixes didn't apply to the daily pattern of detections plot for vessels. That one still didn't show up. Very strange.

Ah, I thought "Daily patterns" got changed to "Time series" previously:

[x] 7) The detection graphs are not showing up for CINMS humpback whales.

These rows in modals sheet of sanctsound website content got tab_name values changed from "Daily patterns" to "Time series".

I added "Daily patterns" back in with commit https://github.com/noaa-onms/sanctsound/commit/571ecf2081b2e29831ce2179d0fcf77e4b517ec9 so these now show up here:

noaa-onms / sanctsound