search

noah-de / swel

Real time analysis of raw spectral wave information from NOAA, calculating trends by plotting spectral moments.
1 stars 0 forks source link

tests should be relevant and complete #2

Open noah-de opened 5 years ago

noah-de commented 5 years ago

test only what is needed, yet tests should also be complete enough to provide a tool for investigating regression problems.

As it is right now, there is barely enough tests (or functionality).

noah-de commented 5 years ago

Tests should include mocked versions of fetching the data as was done here: https://github.com/Feralo/vanilla_pkg/commit/7b2c3c09e3c6a1e04fcb4557a13ad1beba4ba2ef