noahbaculi / guitar-tab-generator

Generate fingerstyle guitar tabs based on the difficulty of different finger positions
https://noahbaculi.com/guitartab
GNU General Public License v3.0
9 stars 1 forks source link

Suggestion #2

Open r3a1d3a1 opened 8 months ago

r3a1d3a1 commented 8 months ago

Enjoyed reading about the problem and your solution. A minor improvement: Topological sort is slightly faster than Dijkstra: https://en.wikipedia.org/wiki/Shortest_path_problem#Directed_acyclic_graphs_(DAGs)

noahbaculi commented 8 months ago

Hey @r3a1d3a1, that's a great idea! I'd love to see a comparison of both options in this use case. I love the open and collaborative nature of this project and this should be a relatively minor change so feel free to open a PR with some benchmarking! Here are some resources that may be useful:

r3a1d3a1 commented 8 months ago

Second link was pretty cool... Thanks for sharing! #AmortizedAnalysis