search

noahd1 / oink

Log parser to identify actions which significantly increase VM heap size
MIT License
1.18k stars 71 forks source link

wmi creation and threading fix, attempt #2 #17

Closed tyrylu closed 11 years ago

tyrylu commented 12 years ago

This is the promised pull request. Now, there are 6 additions and one deletion which i do not quite understand why it is here. But it probably looks better than the previous attempt. For details, see the comments in the ruby sources.

KelseyDH commented 10 years ago

I recently had an issue with the default code used by Oink here on a Windows machine, so some solution or fix should be considered as it's currently breaking for Windows users on older Rails projects:

WIN32OLERuntimeError in Devise::SessionsController#new

failed to parse display name of moniker `winmgmts:root/cimv2' HRESULT error code:0x800401e4 Invalid syntax Rails.root: C:/RailsInstaller/Ruby1.9.3/project-name

Application Trace | Framework Trace | Full Trace oink (0.9.3) lib/oink/instrumentation/memory_snapshot.rb:31:in connect' oink (0.9.3) lib/oink/instrumentation/memory_snapshot.rb:31:inmemory' oink (0.9.3) lib/oink/instrumentation/memory_snapshot.rb:7:in memory' oink (0.9.3) lib/oink/middleware.rb:41:inlog_memory' oink (0.9.3) lib/oink/middleware.rb:20:in call' pdfkit (0.5.2) lib/pdfkit/middleware.rb:16:incall' warden (1.1.1) lib/warden/manager.rb:35:in `block in call' ...

At the very least add a message about this in the documentation.