Check for exit status immediately after running command

noahd1 / oink

Log parser to identify actions which significantly increase VM heap size

MIT License

1.18k stars 71 forks source link

Check for exit status immediately after running command #26

Closed pmarreck closed 11 years ago

pmarreck commented 11 years ago

Just drive-by editing, thought it made more sense to collect the exit status immediately when the cmd is run to avoid potential TOCTOU bugs http://en.wikipedia.org/wiki/Time-of-check-to-time-of-use (although it still doesn't guarantee the elimination)