noahd1 / oink

Log parser to identify actions which significantly increase VM heap size
MIT License
1.18k stars 71 forks source link

How does Oink Deal with Threads? #42

Open schneems opened 8 years ago

schneems commented 8 years ago

Sorry for opening an issue to ask a general question.

How does Oink deal with threaded webservers? For example if i'm running puma with 5 threads and each start serving a request A,B,C,D, & E. If Oink is measuring memory by wrapping the request for A and then in the middle B gets hit with a REALLY expensive endpoint, if you're taking process memory it might look like A was at fault. Does Oink handle that well? Does it use statistics to see what requests consistently use more memory?

Thanks for your work on this gem and in for working in the Ruby memory space.

stereobooster commented 7 years ago

As far as I see Oink measure memory of process (based on PID), so it does not support measuring separate threads