search

noahgibbs / rsb

Rails Simpler Bench - a simple Rails app, with a variety of requests and Ruby versions that it can be tested with
42 stars 6 forks source link

bigdecimal only has a C extension, won't install on JRuby #12

Open headius opened 4 years ago

headius commented 4 years ago

The bigdecimal gem only contains the C extension version of that library, which means it cannot install on JRuby.

It should be removed until we can get the JRuby bigdecimal bits (or a stub) into the bigdecimal gem.

headius commented 4 years ago

Or instead of removed, marked for just the "ruby" platform.

noahgibbs commented 4 years ago

Sounds like a good idea. I find that in CRuby 2.7, Rails 2.4 fails without it. But if JRuby's 2.7-compatible versions don't have the same problem, there's no reason to lock the bigdecimal version for them.

headius commented 4 years ago

What is the problem?

noahgibbs commented 4 years ago

Rails 2.4 uses a deprecated BigDecimal constructor. By specifying an earlier version of BigDecimal, I get one where that constructor is still permissible.

On Fri, Aug 28, 2020 at 3:33 PM Charles Oliver Nutter < notifications@github.com> wrote:

What is the problem?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/noahgibbs/rsb/issues/12#issuecomment-682626058, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUD2HHL33XSYQMIUQL6HLSC655BANCNFSM4QNHN5IQ .