Make #server_cleanup more robust by sending SIGKILL if the server did not terminate in 3s

noahgibbs / rsb

Rails Simpler Bench - a simple Rails app, with a variety of requests and Ruby versions that it can be tested with

42 stars 6 forks source link

Make #server_cleanup more robust by sending SIGKILL if the server did not terminate in 3s #3

Closed eregon closed 5 years ago

eregon commented 5 years ago

From https://github.com/noahgibbs/rsb/pull/2#discussion_r287780649

I tested the code in various situations, such as with a leftover process from a previous run and a process not responding to SIGINT. It seems to work fine.

cc @noahgibbs