Use the same shell for :ruby_subprocess_cmd

noahgibbs / rsb

Rails Simpler Bench - a simple Rails app, with a variety of requests and Ruby versions that it can be tested with

42 stars 6 forks source link

Use the same shell for :ruby_subprocess_cmd #5

Closed eregon closed 5 years ago

eregon commented 5 years ago

For instance, I use ZSH and this would shell out to Bash which uses a completely different config.
-l is also harmful in that it resets the PATH instead of inheriting from the parent process.

noahgibbs commented 5 years ago

One difficulty here is that without the "bash -l" wrapper, rvm doesn't reliably work. That's why it's there. I'll look at whether I can move that out into the rvm-savvy runner scripts, though...

noahgibbs commented 5 years ago

(Similarly, it's possible to get around this by overriding ruby_subprocess_cmd in the runner)

eregon commented 5 years ago

Maybe using rvm do would work then? https://rvm.io/workflow/scripting

@mpapis @pkuczynski What would you recommend to spawn a command under a selected ruby?

eregon commented 5 years ago

@noahgibbs I updated the PR to still wrap in bash -l -c "COMMAND" for RVM, but not wrap in other cases.

noahgibbs commented 5 years ago

This looks like a great way to handle it. Thanks!

eregon commented 5 years ago

Thanks for merging!