Closed eregon closed 5 years ago
Travis seems reasonable. I haven't used it here yet, but it's high time.
I notice that you changed the sense of "no_check_url" to "check_url", which is good practice and looks good.
I'm fine with adding new runners.
The new Gemfile-2.0.0 is reasonable. I have separate ones for p0 and p648, but that's a relic and can be removed. I'm in the process of adding dynamic Gemfile generation (the commits are in, but apparently it's broken for you? Getting there...) But no harm in adding another Gemfile in the mean time.
Thanks for merging!
I added Gemfile-2.0.0
simply because that's what gets used when using RUBY_VERSION
to select the Gemfile. It would probably be simpler to use RUBY_VERSION
to select the Gemfile for other runners as well, or maybe it's not necessary anymore with Gemfile generation.
There is a lot less need for it with Gemfile generation - if that basically works for you then the only reason to specify a Gemfile is if you want something specific (e.g. pry, specific gem for speed-testing, specific gem version for compatibility.)
Also includes the commit from https://github.com/noahgibbs/rsb/pull/5
The new runner is more convenient (tweaking values is trivial, and it's self-documenting) when testing just one Ruby and analyzing performance, and when running the benchmark in an automated manner for just one Ruby implementation at a time.
The TravisCI config ensures both the rack and rails apps work on 2.6.3 and 2.0.0. Here is the latest run: https://travis-ci.org/eregon/rsb/builds/587827779
@noahgibbs What do you think? Could you enable TravisCI on this repo?