search

noahgibbs / rsb

Rails Simpler Bench - a simple Rails app, with a variety of requests and Ruby versions that it can be tested with
42 stars 6 forks source link

Dynamic Gemfile fixes #7

Closed eregon closed 5 years ago

eregon commented 5 years ago

This lets the dynamic Gemfile works for the current_ruby_cli.rb runner too, and shares the logic between all 3 runners.

noahgibbs commented 5 years ago

This looks excellent. Thank you!

eregon commented 5 years ago

@noahgibbs Thanks for merging! Could you enable TravisCI on this repo?

noahgibbs commented 5 years ago

I'm... attempting to? Travis seems to automatically pick up organisations that use it, and so I'm having a lot of trouble turning on Travis for this as a personal open-source repository and just getting it to build...

noahgibbs commented 5 years ago

Okay, looks like it's building now.

noahgibbs commented 5 years ago

https://travis-ci.org/noahgibbs/rsb

noahgibbs commented 5 years ago

Ah, okay. I turned it on with the legacy "GitHub Services" interface, and more recently I should use GitHub Apps, with which I am not yet familiar.

noahgibbs commented 5 years ago

K. It's broken. I've filed a bug for me to fix it soon :-)

eregon commented 5 years ago

@noahgibbs Thanks! Great to see it's working on Ruby 2.6 at least :)