search

noahgsolomon / brainrot.js

Text to video generator in the brainrot form. Learn about any topic from your favorite personalities 😼.
https://brainrotjs.com
MIT License
486 stars 54 forks source link

FPS output does not allow uploading to tiktok #2

Closed shagg-e closed 4 months ago

shagg-e commented 4 months ago

It seems the videos are being output at 60.0x fps, which is just barely above Tiktok's limit of 60fps. I've tried a few videos and they're all just barely too much FPS. Works fine for Youtube though.

noahgsolomon commented 4 months ago

interesting... is this on brainrotjs.com or when you generate a video locally?

shagg-e commented 4 months ago

On the website - interestingly enough I just did some additional testing. I use Simplified to post to all platforms I post on from one interface, and Simplified complained that it was too high framerate for Tiktok. Uploading directly on Tiktok though worked fine. My best guess is that Tiktok native allows a little wiggleroom, but Simplified does not and is very strict?

Rendering at 59fps could solve this I bet. Will there be any controls for things like framerate, video length, etc? Youtube does not consider them shorts unfortunately from my few test uploads just now, since they're all 1:00-1:01 long.

On Wed, Apr 10, 2024 at 1:58 PM Noah Solomon @.***> wrote:

interesting... is this on brainrotjs.com or when you generate a video locally?

— Reply to this email directly, view it on GitHub https://github.com/noahgsolomon/brainrot.js/issues/2#issuecomment-2048236457, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIVTUW7V6743NCVZYKDK733Y4WDXFAVCNFSM6AAAAABGA6F6MCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBYGIZTMNBVG4 . You are receiving this because you authored the thread.Message ID: @.***>

noahgsolomon commented 4 months ago

yeah look at generate/src/Root.tsx and generate/src/Composition.tsx

they're in the code defaulted to 20 but can be changed to anything