search

noahm / DDRCardDraw

Card draw / randomizer for use in music game tournaments including DDR, SMX, ITG, and PIU
https://ddr.tools
BSD 2-Clause "Simplified" License
33 stars 34 forks source link

Use matrix strategy for checks #356

Closed ScottBrenner closed 2 months ago

ScottBrenner commented 3 months ago

Converting the workflow here to use a matrix strategy, reference https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ddr-tools ✅ Ready (Inspect) Visit Preview Aug 7, 2024 3:33am
noahm commented 3 months ago

Thanks for helping to clean up some of that boilerplate! Unfortunately it seems like the resulting titles from the checks are significantly less clear, especially for newcomers to the project. I'm not familiar enough with github actions to know if there's an easy way to improve this when using a matrix strategy. Do you have any ideas on this front?

Before: image After this PR: image

ScottBrenner commented 3 months ago

Yea was wondering about that, added some more text with https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/using-a-matrix-for-your-jobs#expanding-or-adding-matrix-configurations but I'm not sure if it can match how things are titled currently

noahm commented 2 months ago

Finally merging now that I have a moment to update the required checks settings to go along with it. Thanks for the contribution again!