fix(renderer): allow unicode for no-escape variables

noahmorrison / chevron

A Python implementation of mustache

MIT License

505 stars 55 forks source link

fix(renderer): allow unicode for no-escape variables #29

Closed lksnmnn closed 6 years ago

lksnmnn commented 6 years ago

Issue

See Issue https://github.com/noahmorrison/chevron/issues/28 for more details.

Changes

Add unicode parsing for 'no-escape' case
Add test case for parsing unicode without escaping HTML

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling 87099af7c2a1ce0e768f4c30ce6f84a3f2897383 on lksnmnn:fix-utf8-encoding into 8dbc2cb57ff626065ba67bd914e5eed5432ffd63 on noahmorrison:master.

lksnmnn commented 6 years ago

I am not familiar with Tox so I do not know how to fix the failing CI job, but it should have nothing to do with my changes.

lksnmnn commented 6 years ago

@noahmorrison Are you still maintaining this package? I am happy to help.

samuelcolvin commented 6 years ago

In the past @noahmorrison responded and help eventually.

We too are actively using this repr so are happy to help maintain.

lksnmnn commented 6 years ago

It seems he can cross out the first two TODOs in the Readme.md ;)

noahmorrison commented 6 years ago

Hey guys, I have no idea why tox failed. It only failed on python 3.3 which I tried on my local machine and it worked fine.

Merging this fix in, thanks for the unittest.

Still happy to see this project being used :)