search

noahmorrison / chevron

A Python implementation of mustache
MIT License
486 stars 52 forks source link

Fix SyntaxWarning over comparison of literals using is #70

Closed tirkarthi closed 3 years ago

tirkarthi commented 4 years ago

Fixes #66

smurfix commented 4 years ago

Is there a problem with this merge request?

The bug triggers a SyntaxWarning on Python 3.8. Please release a fixed version ASAP.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 10fb9ced692c3770e9522e0959cd4eed335caeea on tirkarthi:fix-syntax-warning into 78f1a384eddef16906732d8db66deea6d37049b7 on noahmorrison:master.

mrichman commented 4 years ago

I still get this warning using 0.13.1: /var/task/chevron/renderer.py:73: SyntaxWarning: "is" with a literal. Did you mean "=="?

tim-pugh commented 3 years ago

@mrichman I don't believe it was pulled into the master branch yet, but only made it's way through the CI/CD pipeline (maybe I'm wrong here assuming that). However, from what I can see:

https://github.com/noahmorrison/chevron/blob/78f1a384eddef16906732d8db66deea6d37049b7/chevron/renderer.py#L78

it doesn't appear so. I also see you raised issue #75; I'll try to jump on that one and ask the other dev to peek in here and see if my assumption is correct and see if they have the correct permissions to merge, unless someone else is reading this <:o)

theshadow27 commented 3 years ago

+1 on the issue with 3.8. Is there an ETA on getting this merged?

noahmorrison commented 3 years ago

merged