search

noahmorrison / chevron

A Python implementation of mustache
MIT License
486 stars 52 forks source link

SyntaxWarning: "is" with a literal. Did you mean "=="? #75

Closed mrichman closed 3 years ago

mrichman commented 4 years ago

I get this warning using 0.13.1: /var/task/chevron/renderer.py:73: SyntaxWarning: "is" with a literal. Did you mean "=="? if scope is 0:

davepeck commented 4 years ago

I see this too. But the line of code in question has a # noqa: F632 which I think should silence flake8. Hrm.

tim-pugh commented 3 years ago

@davepeck can you peek at #70 ? Think that may fix the issue, but hasn't been merged.

There is another codebase were we pull this in as a dependency and lock the version, so I'm hopeful if we can get this pulled into the master branch I can raise a PR on that repo.

noahmorrison commented 3 years ago

This is merged into the main branch now. Will try to publish a v0.14.0 to pypi today