Update for configurable jupiter_swap_api

noahtheprogrammer / soltrade

Python trading bot using the Solana blockchain.

https://discord.gg/WDS9Ya8KvX

GNU General Public License v3.0

202 stars 90 forks source link

Update for configurable jupiter_swap_api #19

Closed zer0cache closed 7 months ago

zer0cache commented 8 months ago

This PR updates soltrade to have the Jupiter Swap API as a configuration with a fallback in case one isn't provided. This allows you to easily swap to a self hosted Jupiter API instance if you choose.

abunsen commented 8 months ago

wow looks cool, would use

noahtheprogrammer commented 8 months ago

While I appreciate your interesting in adding such a feature, I'm afraid that I cannot merge your pull request, as this feature would not function properly due to Soltrade's reliance on the latest Jupiter features, such as that of Versioned Transactions, which if I recall are only supported in the last two versions of the API. Additionally, the documentation explaining the parameter is quite vague.

zer0cache commented 8 months ago

hey @noahtheprogrammer - great feedback!

re: Latest versions of the API - jupiterapi.com is currently running on the latest version (v6.0.12) and gets updated every time there is a new release.
+1 on documentation - it is currently running the self hosted V6 Swap API, which providers faster latency and higher rate limits than what is currently offered at https://quote-api.jup.ag/v6.

Is there something documentation wise you'd like to see that isn't available on the jup.ag docs?

noahtheprogrammer commented 7 months ago

Sorry, but Jupiter has this link flagged as a malicious website. I will close this pull request now.